Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating pyvista doc dependency #2411

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 13, 2023

As the title.

Close #2410

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 enabled auto-merge (squash) October 13, 2023 09:32
@germa89 germa89 self-assigned this Oct 13, 2023
@germa89 germa89 added the BUG Issue, problem or error in PyMAPDL label Oct 13, 2023
@github-actions github-actions bot added Maintenance General maintenance of the repo (libraries, cicd, etc) Dependencies labels Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2411 (556afe7) into main (efb6728) will increase coverage by 5.99%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2411      +/-   ##
==========================================
+ Coverage   81.93%   87.93%   +5.99%     
==========================================
  Files          44       44              
  Lines        8453     8453              
==========================================
+ Hits         6926     7433     +507     
+ Misses       1527     1020     -507     

@germa89
Copy link
Collaborator Author

germa89 commented Oct 13, 2023

LGTM

Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit 5040f12 into main Oct 13, 2023
24 checks passed
@germa89 germa89 deleted the fix/update-pyvista-doc-dependency branch October 13, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot duplicating PRs
2 participants