Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing "Attaching modified files to PR" #2439

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 20, 2023

By adding more permissions to the workflow.

Close #2438

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Oct 20, 2023
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) BUG Issue, problem or error in PyMAPDL labels Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #2439 (19169a2) into main (758d51b) will decrease coverage by 6.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2439      +/-   ##
==========================================
- Coverage   87.92%   81.88%   -6.04%     
==========================================
  Files          44       44              
  Lines        8453     8453              
==========================================
- Hits         7432     6922     -510     
- Misses       1021     1531     +510     

@germa89
Copy link
Collaborator Author

germa89 commented Oct 25, 2023

Presumably this PR should pass, so we can then merge this into Dependabot failing PRs.

Can you review @clatapie ??

@germa89
Copy link
Collaborator Author

germa89 commented Oct 25, 2023

LGTM.

@germa89 germa89 enabled auto-merge (squash) October 25, 2023 10:45
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit afe9b86 into main Oct 25, 2023
25 checks passed
@germa89 germa89 deleted the fix/file-attacher-to-PR branch October 25, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot's PRs fail because of lack of permissions to push
2 participants