Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing save_selection and small change in Components API #2454

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 26, 2023

Main changes:

  • Implementing save_selection context manager. This context manager takes care to save the current selection (ENTITIES, nodes, elements, kps, lines, areas, and volumes). The entities selection wasn't taking into account before (bug), for instance in mapdl.vplot (See Plot command deletes component names (named selections/cm) #2452).
  • Adding components.select to easier select many components.
  • Changing name to Components.list .. it returns a tuple. Now it is Components.names
  • Making some methods, properties. For instance Components.names() and Components.types

Close #2452

Fixing selection bug.
Adding `components.select`.
Making some methods, properties.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 requested a review from koubaa October 26, 2023 20:35
@germa89 germa89 self-assigned this Oct 26, 2023
@germa89 germa89 added BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature labels Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #2454 (122eb47) into main (1fe9f79) will decrease coverage by 0.01%.
Report is 7 commits behind head on main.
The diff coverage is 90.19%.

@@            Coverage Diff             @@
##             main    #2454      +/-   ##
==========================================
- Coverage   88.09%   88.08%   -0.01%     
==========================================
  Files          44       44              
  Lines        8603     8613      +10     
==========================================
+ Hits         7579     7587       +8     
- Misses       1024     1026       +2     

@germa89 germa89 requested a review from clatapie October 27, 2023 09:43
@germa89 germa89 enabled auto-merge (squash) October 27, 2023 09:44
@germa89 germa89 merged commit 387e428 into main Oct 27, 2023
25 checks passed
@germa89 germa89 deleted the fix/missing-cmselection-after-vplot branch October 27, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot command deletes component names (named selections/cm)
2 participants