Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving functions to Mapdl class #2468

Merged
merged 28 commits into from
Nov 21, 2023
Merged

Moving functions to Mapdl class #2468

merged 28 commits into from
Nov 21, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 2, 2023

Move all the non-default code in Commands_ class to child Mapdl class.

Close #2434

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 2, 2023
@germa89 germa89 added the Enhancement Improve any current implemented feature label Nov 2, 2023
@germa89 germa89 requested a review from clatapie November 2, 2023 15:10
@germa89 germa89 enabled auto-merge (squash) November 2, 2023 15:10
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Nov 2, 2023
@germa89 germa89 disabled auto-merge November 3, 2023 19:43
@germa89 germa89 changed the title Feat/moving-functions-to-mapdl-classes Moving functions to mapdl classes Nov 3, 2023
@germa89 germa89 changed the title Moving functions to mapdl classes Moving functions to Mapdl class Nov 3, 2023
@germa89 germa89 enabled auto-merge (squash) November 6, 2023 12:28
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023 •
edited

Codecov Report

Merging #2468 (b7c8f92) into main (949b8d8) will increase coverage by 0.04%.
Report is 6 commits behind head on main.
The diff coverage is 93.93%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2468      +/-   ##
==========================================
+ Coverage   83.83%   83.88%   +0.04%     
==========================================
  Files          44       44              
  Lines        8685     8749      +64     
==========================================
+ Hits         7281     7339      +58     
- Misses       1404     1410       +6

@germa89
Copy link
Collaborator Author

germa89 commented Nov 20, 2023

Still waiting for a review on this... @clatapie

@germa89
Copy link
Collaborator Author

germa89 commented Nov 21, 2023 •
edited

LGTM

pyansys-ci-bot
pyansys-ci-bot approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit 94320a6 into main Nov 21, 2023
26 checks passed
@germa89 germa89 deleted the feat/moving-functions-to-mapdl-classes branch November 21, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie

@RobPasMue RobPasMue Awaiting requested review from RobPasMue

Assignees

@germa89 germa89

Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move code from autogenerated classes to Mapdl classes
2 participants
@germa89 @pyansys-ci-bot