Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting the python upper version to 3.11 #2469

Merged
merged 11 commits into from
Nov 6, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 2, 2023

Until pyvista (and hence vtk) supports python 3.12. We are stuck on 3.11.

Close #2427

Collecting vtk>=9.0.0 (from ansys-mapdl-core==0.68.dev0)
  Using cached vtk-9.2.6-cp311-cp311-macosx_11_0_arm64.whl (58.9 MB)
INFO: pip is looking at multiple versions of ansys-mapdl-core to determine which version is compatible with other requirements. This could take a while.
ERROR: Package 'ansys-mapdl-core' requires a different Python: 3.11.6 not in '<3.11.0,>=3.8.1'

[notice] A new release of pip is available: 23.2.1 -> 23.3.1
[notice] To update, run: pip install --upgrade pip
(tempvenv) german.ayuso@Ansys-WYN9VF7KGG pymapdl % 

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added Maintenance General maintenance of the repo (libraries, cicd, etc) Dependencies labels Nov 2, 2023
@germa89 germa89 self-assigned this Nov 2, 2023
@germa89 germa89 enabled auto-merge (squash) November 2, 2023 15:21
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2469 (bd6f29c) into main (03c9db3) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2469      +/-   ##
==========================================
+ Coverage   83.51%   83.78%   +0.27%     
==========================================
  Files          44       44              
  Lines        8660     8660              
==========================================
+ Hits         7232     7256      +24     
+ Misses       1428     1404      -24     

pyproject.toml Outdated Show resolved Hide resolved
@germa89 germa89 disabled auto-merge November 3, 2023 19:41
@RobPasMue
Copy link
Member

By the way, why >=3.8.1 and not just 3.8?

@germa89
Copy link
Collaborator Author

germa89 commented Nov 6, 2023

By the way, why >=3.8.1 and not just 3.8?

Because I miss read a comment in stackoverflow so I thought I had to specify the 3 digits version. But it is not needed indeed.

pyproject.toml Outdated Show resolved Hide resolved
@germa89 germa89 enabled auto-merge (squash) November 6, 2023 09:22
@germa89 germa89 merged commit eec59a2 into main Nov 6, 2023
24 checks passed
@germa89 germa89 deleted the maint/limit-python-to-3.11 branch November 6, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit the python version to <3.12
2 participants