Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vale 2.29.6 #2475

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Fix vale 2.29.6 #2475

merged 5 commits into from
Nov 3, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 3, 2023

As the title.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) BUG Issue, problem or error in PyMAPDL labels Nov 3, 2023
@germa89 germa89 self-assigned this Nov 3, 2023
@germa89 germa89 enabled auto-merge (squash) November 3, 2023 14:37
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2475 (627d423) into main (d89968a) will decrease coverage by 0.27%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head 627d423 differs from pull request most recent head 5184e5d. Consider uploading reports for the commit 5184e5d to get more accurate results

@@            Coverage Diff             @@
##             main    #2475      +/-   ##
==========================================
- Coverage   83.76%   83.49%   -0.27%     
==========================================
  Files          44       44              
  Lines        8660     8660              
==========================================
- Hits         7254     7231      -23     
- Misses       1406     1429      +23     

@germa89
Copy link
Collaborator Author

germa89 commented Nov 3, 2023

Because it is a blocker... LGTM.

Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2475 (5184e5d) into main (d89968a) will decrease coverage by 6.11%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2475      +/-   ##
==========================================
- Coverage   83.76%   77.65%   -6.11%     
==========================================
  Files          44       44              
  Lines        8660     8660              
==========================================
- Hits         7254     6725     -529     
- Misses       1406     1935     +529     

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2475 (5184e5d) into main (d89968a) will decrease coverage by 0.29%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2475      +/-   ##
==========================================
- Coverage   83.76%   83.47%   -0.29%     
==========================================
  Files          44       44              
  Lines        8660     8660              
==========================================
- Hits         7254     7229      -25     
- Misses       1406     1431      +25     

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2475 (2c00eaf) into main (d89968a) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2475   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files          44       44           
  Lines        8660     8660           
=======================================
  Hits         7254     7254           
  Misses       1406     1406           

@germa89 germa89 merged commit 03c9db3 into main Nov 3, 2023
23 checks passed
@germa89 germa89 deleted the fix/vale-issues branch November 3, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc Documentation Documentation related (improving, adding, etc) Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants