Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing plot indexing #2476

Merged
merged 10 commits into from
Nov 6, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 3, 2023

While working in #2471 I found out that test_plot_incomplete_nodal_selection was not passing, not sure what did I change in that PR (I check I promise).

Hence I'm bringing the fix I did for that in a separate PR to highlight its importance.

I have also extensively documented the approach so the future developers (me) know what I did.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 3, 2023
@germa89 germa89 added BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature labels Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2476 (8423731) into main (d89968a) will increase coverage by 0.04%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2476      +/-   ##
==========================================
+ Coverage   83.76%   83.81%   +0.04%     
==========================================
  Files          44       44              
  Lines        8660     8660              
==========================================
+ Hits         7254     7258       +4     
+ Misses       1406     1402       -4     

@germa89
Copy link
Collaborator Author

germa89 commented Nov 6, 2023

Needed, so ... LGTM.

@germa89 germa89 enabled auto-merge (squash) November 6, 2023 12:29
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit ff8ea46 into main Nov 6, 2023
26 checks passed
@germa89 germa89 deleted the fix/indexing-when-plotting-uncompleted-mesh branch November 6, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants