Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing memory limitations in dockerizer jobs #2483

Merged
merged 10 commits into from
Nov 8, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 7, 2023

As the title

Recent discussion in here #2479, led me to think that limiting the amount of memory used by docker container can improve its stability.
Therefore I'm limiting the amount of memory (--memory) to 6.5GB of RAM, and the amount of swap (--memory-swap) to the RAM (6.5GB) plus 10GB of the 14GB of the SSD memory (16.5GB).
I am also disabling out-of-memory killing (--oom-kill-disable) so the container will use all the memory available without being killed. Probably it wont be needed if memory is limited.

References:

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2483 (4531f49) into main (c1ea52c) will decrease coverage by 0.11%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2483      +/-   ##
==========================================
- Coverage   83.94%   83.83%   -0.11%     
==========================================
  Files          44       44              
  Lines        8675     8675              
==========================================
- Hits         7282     7273       -9     
- Misses       1393     1402       +9     

@germa89 germa89 self-assigned this Nov 7, 2023
@germa89 germa89 requested a review from koubaa November 7, 2023 10:12
@germa89 germa89 enabled auto-merge (squash) November 7, 2023 17:18
@germa89 germa89 merged commit 7674756 into main Nov 8, 2023
26 checks passed
@germa89 germa89 deleted the ci/limiting-memory-in-docker-image-runs branch November 8, 2023 12:32
clatapie added a commit that referenced this pull request Nov 17, 2023
germa89 added a commit that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants