Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding running get_array and non_interactive raising exceptions #2484

Merged
merged 7 commits into from
Nov 8, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 7, 2023

  • Not running get_array in non_interactive
  • Early exit of non_interactive cont manager when an exception is raised inside.
  • Clarifying exceptions messages

Close #2480

* Clarifying exceptions messages
* Early exit of `non_interactive` cont manager when an exception is raised inside.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 7, 2023
@germa89 germa89 requested a review from clatapie November 7, 2023 11:51
@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label Nov 7, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2484 (21a423a) into main (c1ea52c) will decrease coverage by 0.14%.
Report is 4 commits behind head on main.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##             main    #2484      +/-   ##
==========================================
- Coverage   83.94%   83.81%   -0.14%     
==========================================
  Files          44       44              
  Lines        8675     8685      +10     
==========================================
- Hits         7282     7279       -3     
- Misses       1393     1406      +13     

@germa89
Copy link
Collaborator Author

germa89 commented Nov 8, 2023

I'm going to ignore coverage for this specific PR because it is for edge cases difficult to cover.

@germa89 germa89 merged commit 428fba2 into main Nov 8, 2023
25 of 26 checks passed
@germa89 germa89 deleted the fix/not-allowing-get_array-in-non_interactive-mode branch November 8, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mapdl.get_array gets executed in non-interactive
1 participant