Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing skip regression check cli argument #2487

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 7, 2023

As the title.

This argument is not needed since the extension provides ignore_image_cache.

Close #2472

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 7, 2023
@germa89 germa89 requested a review from clatapie November 7, 2023 17:31
@germa89 germa89 added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Nov 7, 2023
@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2487 (4063a76) into main (949b8d8) will decrease coverage by 0.03%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2487      +/-   ##
==========================================
- Coverage   83.83%   83.81%   -0.03%     
==========================================
  Files          44       44              
  Lines        8685     8685              
==========================================
- Hits         7281     7279       -2     
- Misses       1404     1406       +2     

@germa89
Copy link
Collaborator Author

germa89 commented Nov 20, 2023

LGTM

@germa89 germa89 enabled auto-merge (squash) November 20, 2023 14:48
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit ccb5050 into main Nov 20, 2023
26 checks passed
@germa89 germa89 deleted the fix/removing-skip-regression-test-option branch November 20, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--skip-regression-check seems to not skip the regression tests
2 participants