Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve launcher documentation #2488

Merged
merged 14 commits into from
Nov 21, 2023
Merged

Improve launcher documentation #2488

merged 14 commits into from
Nov 21, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 7, 2023

As the title.

Close #2367
Close #2462

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 7, 2023
@germa89 germa89 added the Documentation Documentation related (improving, adding, etc) label Nov 7, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited

Codecov Report

Merging #2488 (20650f5) into main (949b8d8) will decrease coverage by 0.03%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2488      +/-   ##
==========================================
- Coverage   83.83%   83.81%   -0.03%     
==========================================
  Files          44       44              
  Lines        8685     8685              
==========================================
- Hits         7281     7279       -2     
- Misses       1404     1406       +2

@germa89 germa89 requested a review from koubaa November 7, 2023 23:34
PipKat
PipKat reviewed Nov 9, 2023
View reviewed changes
src/ansys/mapdl/core/pool.py Outdated Show resolved Hide resolved
PipKat
PipKat approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@germa89 germa89 enabled auto-merge (squash) November 20, 2023 17:43
@germa89 germa89 merged commit cbadf18 into main Nov 21, 2023
26 checks passed
@germa89 germa89 deleted the doc/improve-launcher-documentation branch November 21, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koubaa koubaa koubaa approved these changes

@PipKat PipKat PipKat approved these changes

@clatapie clatapie Awaiting requested review from clatapie

Assignees

@germa89 germa89

Labels
Documentation Documentation related (improving, adding, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify functions for launching MAPDL in different cases PyMAPDL connect to remote instance section
3 participants
@germa89 @koubaa @PipKat