Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing vm step from minimal #2492

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Removing vm step from minimal #2492

merged 1 commit into from
Nov 8, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 7, 2023

As the title. That step is buggy.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 7, 2023
@germa89 germa89 added BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc labels Nov 7, 2023
@germa89 germa89 requested a review from clatapie November 7, 2023 23:37
@germa89
Copy link
Collaborator Author

germa89 commented Nov 7, 2023

LGTM.

@germa89 germa89 enabled auto-merge (squash) November 7, 2023 23:38
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@github-actions github-actions bot added the Maintenance General maintenance of the repo (libraries, cicd, etc) label Nov 7, 2023
@germa89 germa89 changed the title Removing vm step from minimal. It is buggy. Removing vm step from minimal Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2492 (ba32063) into main (03c9db3) will increase coverage by 0.36%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2492      +/-   ##
==========================================
+ Coverage   83.51%   83.87%   +0.36%     
==========================================
  Files          44       44              
  Lines        8660     8675      +15     
==========================================
+ Hits         7232     7276      +44     
+ Misses       1428     1399      -29     

@germa89 germa89 merged commit e1668a1 into main Nov 8, 2023
29 checks passed
@germa89 germa89 deleted the ci/removing-vms-from-minimal branch November 8, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants