Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delaying codecov report until CI is finished #2495

Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 8, 2023

It is quite annoying to see a failed job because a slow job hasn't yet submitted its coverage report yet.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 8, 2023
@germa89 germa89 requested a review from clatapie November 8, 2023 11:03
@github-actions github-actions bot added Maintenance General maintenance of the repo (libraries, cicd, etc) CI/CD Related with CICD, Github Actions, etc labels Nov 8, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Nov 8, 2023

if wait for ci does not work, I will test:

codecov:
  notify:
    after_n_builds: 2

https://community.codecov.com/t/github-status-notification-isnt-delayed-should-wait-all-ci-jobs-to-finish/3708/14

Codecov
Hi @tom, thanks for the update. Unfortunately, no change. 😬 After ~1 min; After ~2 mins: Commtit: https://github.com/Delgan/codecov-status-test/commit/2088269f923d6ecbdb119c1a7c2ca027975b495b

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2495 (d7d32a5) into main (c1ea52c) will decrease coverage by 0.09%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2495      +/-   ##
==========================================
- Coverage   83.94%   83.86%   -0.09%     
==========================================
  Files          44       44              
  Lines        8675     8675              
==========================================
- Hits         7282     7275       -7     
- Misses       1393     1400       +7     

@germa89 germa89 requested a review from a team November 8, 2023 16:13
@germa89
Copy link
Collaborator Author

germa89 commented Nov 8, 2023

Pinging @ansys/pyansys-core for visibility

@germa89
Copy link
Collaborator Author

germa89 commented Nov 8, 2023

LGTM

@germa89 germa89 enabled auto-merge (squash) November 8, 2023 16:13
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit 949b8d8 into main Nov 8, 2023
26 checks passed
@germa89 germa89 deleted the ci/delaying-coverage-report-until-all-the-builds-are-finished branch November 8, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants