Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Python 3.12 #2507

Merged
merged 6 commits into from
Nov 20, 2023
Merged

feat: add support for Python 3.12 #2507

merged 6 commits into from
Nov 20, 2023

Conversation

RobPasMue
Copy link
Member

As title says

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@RobPasMue RobPasMue self-assigned this Nov 15, 2023
@RobPasMue
Copy link
Member Author

We should also drop support for Python 3.8 at some point @germa89 ... unless strictly necessary

@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) Dependencies Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Nov 15, 2023
@RobPasMue RobPasMue mentioned this pull request Nov 15, 2023
Closed
4 tasks
@RobPasMue
Copy link
Member Author

Requires release of ansys-mapdl-reader

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited

Codecov Report

Merging #2507 (274a6da) into main (949b8d8) will decrease coverage by 0.03%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2507      +/-   ##
==========================================
- Coverage   83.83%   83.81%   -0.03%     
==========================================
  Files          44       44              
  Lines        8685     8685              
==========================================
- Hits         7281     7279       -2     
- Misses       1404     1406       +2

@RobPasMue
Copy link
Member Author

Some stages are failing for "local" builds. I'd suggest merging but I will leave it up to @clatapie and @germa89 to decide...

germa89
germa89 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot @RobPasMue for your valuable contribution!

@germa89 germa89 enabled auto-merge (squash) November 20, 2023 15:01
@germa89 germa89 merged commit 44c4c47 into main Nov 20, 2023
22 checks passed
@germa89 germa89 deleted the feat/add-3.12 branch November 20, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germa89 germa89 germa89 approved these changes

@jorgepiloto jorgepiloto jorgepiloto approved these changes

@clatapie clatapie clatapie approved these changes

Assignees

@RobPasMue RobPasMue

Labels
CI/CD Related with CICD, Github Actions, etc Dependencies Documentation Documentation related (improving, adding, etc) Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RobPasMue @germa89 @jorgepiloto @clatapie