Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inquire return something when no = in response #2522

Merged
merged 23 commits into from
Nov 23, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 22, 2023

As the title.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 changed the title Feat/moving-mapdl-functions-to-class-files Moving functions to MAPDL classes Nov 22, 2023
@germa89

This comment was marked as outdated.

@germa89 germa89 marked this pull request as draft November 22, 2023 12:19
@germa89 germa89 self-assigned this Nov 22, 2023
@germa89

This comment was marked as outdated.

@germa89 germa89 changed the title Moving functions to MAPDL classes inquire return something when no = in response Nov 23, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Nov 23, 2023

Repurposing this PR, because (most of the) changes were already implemented.

@germa89
Copy link
Collaborator Author

germa89 commented Nov 23, 2023

LGTM

@germa89 germa89 added the Enhancement Improve any current implemented feature label Nov 23, 2023
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 marked this pull request as ready for review November 23, 2023 13:43
@germa89 germa89 enabled auto-merge (squash) November 23, 2023 13:43
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #2522 (105a045) into main (df48beb) will decrease coverage by 0.02%.
Report is 4 commits behind head on main.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2522      +/-   ##
==========================================
- Coverage   83.90%   83.88%   -0.02%     
==========================================
  Files          44       44              
  Lines        8755     8757       +2     
==========================================
  Hits         7346     7346              
- Misses       1409     1411       +2     

@germa89 germa89 merged commit 1074bec into main Nov 23, 2023
27 of 28 checks passed
@germa89 germa89 deleted the feat/moving-mapdl-functions-to-class-files branch November 23, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants