Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Dyna explicit commands #2525

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 23, 2023

As the title.

Related to #2494

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Nov 23, 2023
@germa89 germa89 self-assigned this Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #2525 (647c38e) into main (df48beb) will decrease coverage by 1.07%.
Report is 3 commits behind head on main.
The diff coverage is 40.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2525      +/-   ##
==========================================
- Coverage   83.90%   82.84%   -1.07%     
==========================================
  Files          44       44              
  Lines        8755     9045     +290     
==========================================
+ Hits         7346     7493     +147     
- Misses       1409     1552     +143     

@germa89 germa89 enabled auto-merge (squash) November 23, 2023 13:35
@germa89
Copy link
Collaborator Author

germa89 commented Nov 27, 2023

LGTM.

Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit 26f92b0 into main Nov 27, 2023
27 of 28 checks passed
@germa89 germa89 deleted the feat/deprecate-explicit-commands branch November 27, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants