Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing some plot bugs #2537

Merged
merged 12 commits into from
Dec 11, 2023
Merged

Fixing some plot bugs #2537

merged 12 commits into from
Dec 11, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 27, 2023 •
edited

As the title.

Close #2347

Close #2328

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 27, 2023
@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) BUG Issue, problem or error in PyMAPDL labels Nov 27, 2023
@germa89 germa89 requested a review from a team as a code owner November 27, 2023 12:05
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited

Codecov Report

Merging #2537 (ec3ea7f) into main (0a4287e) will increase coverage by 5.81%.
Report is 3 commits behind head on main.
The diff coverage is 90.90%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2537      +/-   ##
==========================================
+ Coverage   76.73%   82.55%   +5.81%     
==========================================
  Files          44       44              
  Lines        9040     9050      +10     
==========================================
+ Hits         6937     7471     +534     
+ Misses       2103     1579     -524

@germa89
Copy link
Collaborator Author

germa89 commented Nov 27, 2023

Failing CICD probably because new docker images:

#2539

@germa89 germa89 marked this pull request as draft November 27, 2023 12:19
@germa89 germa89 marked this pull request as ready for review December 11, 2023 10:19
@germa89 germa89 enabled auto-merge (squash) December 11, 2023 10:19
@germa89
Copy link
Collaborator Author

germa89 commented Dec 11, 2023

LGTM

pyansys-ci-bot
pyansys-ci-bot approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit 00d49f6 into main Dec 11, 2023
28 checks passed
@germa89 germa89 deleted the fix/plot-bugs branch December 11, 2023 10:20
germa89 added a commit that referenced this pull request Dec 14, 2023
@germa89
Revert "Fixing some plot bugs (#2537)"
fc72567 
This reverts commit 00d49f6.
germa89 added a commit that referenced this pull request Dec 15, 2023
@germa89
Reapply "Fixing some plot bugs (#2537)"
c85f92f 
This reverts commit fc72567.
germa89 added a commit that referenced this pull request Dec 15, 2023
@germa89
Fix 2D plate example (#2558)
1913532 
* Adding finish command

* Using solution() call.

* making sure it is not excluded.

* reorder the parts

* Revert "Fixing some plot bugs (#2537)"

This reverts commit 00d49f6.

* Reapply "Fixing some plot bugs (#2537)"

This reverts commit fc72567.

* Undoing components selection. It does not make sense.
@lboucin lboucin mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie

Assignees

@germa89 germa89

Labels
BUG Issue, problem or error in PyMAPDL Documentation Documentation related (improving, adding, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plotting bugs Plotting errors during doc building
2 participants
@germa89 @pyansys-ci-bot