Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing ubuntu CICD #2541

Merged
merged 10 commits into from
Dec 4, 2023
Merged

Fixing ubuntu CICD #2541

merged 10 commits into from
Dec 4, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 29, 2023 •
edited

  • Adding a step to test mapdl process launching
  • Not running CICD in CentOS images older than v22.2.1.

Close #2520

@germa89 germa89 requested a review from a team as a code owner November 29, 2023 12:01
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) BUG Issue, problem or error in PyMAPDL labels Nov 29, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited

Codecov Report

Merging #2541 (045f05c) into main (409222d) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2541      +/-   ##
==========================================
- Coverage   82.56%   82.55%   -0.02%     
==========================================
  Files          44       44              
  Lines        9040     9040              
==========================================
- Hits         7464     7463       -1     
- Misses       1576     1577       +1

@germa89 germa89 self-assigned this Dec 4, 2023
@germa89 germa89 enabled auto-merge (squash) December 4, 2023 15:56
@germa89
Copy link
Collaborator Author

germa89 commented Dec 4, 2023

LGTM

pyansys-ci-bot
pyansys-ci-bot approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 removed the request for review from clatapie December 4, 2023 15:57
@germa89 germa89 disabled auto-merge December 4, 2023 15:58
@germa89 germa89 merged commit 22b346a into main Dec 4, 2023
53 checks passed
@germa89 germa89 deleted the fix/cicd branch December 4, 2023 15:59
@germa89 germa89 mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

Assignees

@germa89 germa89

Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scheduled runs fail
2 participants
@germa89 @pyansys-ci-bot