Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating grpcio and adding missing env var. #2601

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Updating grpcio and adding missing env var. #2601

merged 1 commit into from
Jan 3, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 3, 2024

As the title.

@germa89 germa89 requested a review from a team as a code owner January 3, 2024 13:33
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) Dependencies labels Jan 3, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Jan 3, 2024

@pyansys-ci-bot LGTM

@germa89 germa89 enabled auto-merge (squash) January 3, 2024 13:37
pyansys-ci-bot
pyansys-ci-bot approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@codecov Codecov
Copy link

codecov bot commented Jan 3, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b3d6b1) 81.80% compared to head (b5d5893) 80.11%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2601      +/-   ##
==========================================
- Coverage   81.80%   80.11%   -1.70%     
==========================================
  Files          46       46              
  Lines        9090     9090              
==========================================
- Hits         7436     7282     -154     
- Misses       1654     1808     +154

@germa89 germa89 merged commit 0a5f4fe into main Jan 3, 2024
25 checks passed
@germa89 germa89 deleted the ci/fixing-grpcio-version-and-missing-envvar branch January 3, 2024 13:54
@germa89 germa89 mentioned this pull request Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

Assignees
No one assigned
Labels
CI/CD Related with CICD, Github Actions, etc Dependencies Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germa89 @pyansys-ci-bot