Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making local test parallels when it is not a pull request. #2605

Merged
merged 23 commits into from
Jan 8, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 4, 2024

The idea is to test non-student versions also.

@germa89 germa89 self-assigned this Jan 4, 2024
@germa89 germa89 requested a review from a team as a code owner January 4, 2024 12:10
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 218 lines in your changes are missing coverage. Please review.

Comparison is base (0ceb0fb) 77.94% compared to head (787add1) 65.03%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2605       +/-   ##
===========================================
- Coverage   77.94%   65.03%   -12.92%     
===========================================
  Files          46       47        +1     
  Lines        9118     9340      +222     
===========================================
- Hits         7107     6074     -1033     
- Misses       2011     3266     +1255     

@germa89 germa89 enabled auto-merge (squash) January 6, 2024 02:19
@germa89 germa89 disabled auto-merge January 6, 2024 02:19
@germa89
Copy link
Collaborator Author

germa89 commented Jan 8, 2024

@pyansys-ci-bot LGTM

Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89
Copy link
Collaborator Author

germa89 commented Jan 8, 2024

This has been tested fully here: https://github.com/ansys/pymapdl/actions/runs/7445954565

GitHub
Pythonic interface to MAPDL. Contribute to ansys/pymapdl development by creating an account on GitHub.

@germa89
Copy link
Collaborator Author

germa89 commented Jan 8, 2024

All check in place. I need to update requirements names after this.

@germa89 germa89 merged commit 9bdf196 into main Jan 8, 2024
27 of 29 checks passed
@germa89 germa89 deleted the ci/adding-a-job-which-run-locally-with-full-ubuntu branch January 8, 2024 11:05
@germa89 germa89 mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants