Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Small improvements to unit testing and precommit sections #2621

Merged
merged 6 commits into from
Jan 8, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 8, 2024

As the title.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) CI/CD Related with CICD, Github Actions, etc labels Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 141 lines in your changes are missing coverage. Please review.

Comparison is base (0ceb0fb) 77.94% compared to head (231afc3) 79.01%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2621      +/-   ##
==========================================
+ Coverage   77.94%   79.01%   +1.06%     
==========================================
  Files          46       47       +1     
  Lines        9118     9339     +221     
==========================================
+ Hits         7107     7379     +272     
+ Misses       2011     1960      -51     

@germa89
Copy link
Collaborator Author

germa89 commented Jan 8, 2024

@pyansys-ci-bot LGTM

@germa89 germa89 requested a review from clatapie January 8, 2024 09:31
@germa89 germa89 self-assigned this Jan 8, 2024
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 225b7cc into main Jan 8, 2024
27 of 29 checks passed
@germa89 germa89 deleted the ci/codespaces-quick-fixes-regarding-welcome-page branch January 8, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants