Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoiding different groups in devcontainer dependabot PRs #2631

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Avoiding different groups in devcontainer dependabot PRs #2631

merged 1 commit into from
Jan 8, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 8, 2024

As the title.

@germa89 germa89 requested a review from a team as a code owner January 8, 2024 11:07
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Jan 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited

Codecov Report

Attention: 141 lines in your changes are missing coverage. Please review.

Comparison is base (0ceb0fb) 77.94% compared to head (b2d9adc) 79.03%.
Report is 22 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2631      +/-   ##
==========================================
+ Coverage   77.94%   79.03%   +1.09%     
==========================================
  Files          46       47       +1     
  Lines        9118     9340     +222     
==========================================
+ Hits         7107     7382     +275     
+ Misses       2011     1958      -53

@germa89
Copy link
Collaborator Author

germa89 commented Jan 8, 2024

@pyansys-ci-bot LGTM

@germa89 germa89 enabled auto-merge (squash) January 8, 2024 11:13
pyansys-ci-bot
pyansys-ci-bot approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit a41fe6b into main Jan 8, 2024
26 of 28 checks passed
@germa89 germa89 deleted the ci/dependabot-groups-for-devcontainer branch January 8, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

Assignees
No one assigned
Labels
CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germa89 @pyansys-ci-bot