Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PyMAPDL logo #2647

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Adding PyMAPDL logo #2647

merged 5 commits into from
Jan 11, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 11, 2024

As the title.

Not the best logo though...

Regarding light/dark themes switchers: https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/light-dark.html

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jan 11, 2024
@github-actions github-actions bot added the Documentation Documentation related (improving, adding, etc) label Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (46a18c6) 81.07% compared to head (8ec5a69) 82.27%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2647      +/-   ##
==========================================
+ Coverage   81.07%   82.27%   +1.20%     
==========================================
  Files          47       47              
  Lines        9340     9344       +4     
==========================================
+ Hits         7572     7688     +116     
+ Misses       1768     1656     -112     

@Revathyvenugopal162
Copy link
Contributor

only one comment, It will be better to keep the images inside the _static folder of document source.

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 57963f1 into main Jan 11, 2024
23 of 24 checks passed
@germa89 germa89 deleted the doc/adding-logo branch January 11, 2024 14:29
@germa89
Copy link
Collaborator Author

germa89 commented Jan 11, 2024

Looking good...

image

@Revathyvenugopal162
Copy link
Contributor

image
Dark theme, would you prefer to add black logo on dark theme @germa89 ?

@germa89
Copy link
Collaborator Author

germa89 commented Jan 11, 2024

I dont think we set that in the README in the github site...

Howeverrr... check this https://mapdl.docs.pyansys.com/version/dev/index.html in both themes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants