Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logo based on theme in readme #2649

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Update logo based on theme in readme #2649

merged 9 commits into from
Jan 11, 2024

Conversation

Revathyvenugopal162
Copy link
Contributor

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as draft January 11, 2024 16:10
@github-actions github-actions bot added Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Jan 11, 2024
@germa89
Copy link
Collaborator

germa89 commented Jan 11, 2024 •
edited

It doesn't seem to work: https://github.com/ansys/pymapdl/tree/feat/add-logo-based-on-system-theme

image

@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (46a18c6) 81.07% compared to head (a235775) 65.00%.
Report is 9 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2649       +/-   ##
===========================================
- Coverage   81.07%   65.00%   -16.07%     
===========================================
  Files          47       47               
  Lines        9340     9344        +4     
===========================================
- Hits         7572     6074     -1498     
- Misses       1768     3270     +1502

@Revathyvenugopal162
Copy link
Contributor Author

Revathyvenugopal162 commented Jan 11, 2024 •
edited by unfurl-links bot

It doesn't seem to work: https://github.com/ansys/pymapdl/tree/feat/add-logo-based-on-system-theme

GitHub**GitHub - ansys/pymapdl at feat/add-logo-based-on-system-theme**Pythonic interface to MAPDL. Contribute to ansys/pymapdl development by creating an account on GitHub.

can you please check it now?

GitHub
Pythonic interface to MAPDL. Contribute to ansys/pymapdl development by creating an account on GitHub.

@germa89
Copy link
Collaborator

germa89 commented Jan 11, 2024

Nop

image

Revathyvenugopal162
Revathyvenugopal162 commented Jan 11, 2024
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@germa89
Copy link
Collaborator

germa89 commented Jan 11, 2024

Now it works!

image

@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review January 11, 2024 16:25
germa89
germa89 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is perfect! Thank you a lot @Revathyvenugopal162 !! :D

@germa89 germa89 enabled auto-merge (squash) January 11, 2024 16:36
@germa89 germa89 merged commit 901454d into main Jan 11, 2024
26 of 29 checks passed
@germa89 germa89 deleted the feat/add-logo-based-on-system-theme branch January 11, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germa89 germa89 germa89 approved these changes

Assignees
No one assigned
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Revathyvenugopal162 @germa89