Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix approver #2655

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Fix approver #2655

merged 3 commits into from
Jan 12, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 12, 2024

As the title.

@germa89 germa89 requested a review from a team as a code owner January 12, 2024 12:50
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jan 12, 2024
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Jan 12, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Jan 12, 2024

@pyansys-ci-bot LGTM.

@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (46a18c6) 81.07% compared to head (79425d8) 82.27%.
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2655      +/-   ##
==========================================
+ Coverage   81.07%   82.27%   +1.20%     
==========================================
  Files          47       47              
  Lines        9340     9344       +4     
==========================================
+ Hits         7572     7688     +116     
+ Misses       1768     1656     -112

pyansys-ci-bot
pyansys-ci-bot approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment •
edited by germa89

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit 3eba3cf into main Jan 12, 2024
27 of 28 checks passed
@germa89 germa89 deleted the ci/fix-approver branch January 12, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germa89 @pyansys-ci-bot