Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating verbose #2669

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Deprecating verbose #2669

merged 7 commits into from
Jan 19, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 16, 2024

As the title.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 requested a review from clatapie January 16, 2024 10:06
@germa89 germa89 enabled auto-merge (squash) January 16, 2024 10:06
@github-actions github-actions bot added Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6db007d) 84.80% compared to head (eed9657) 82.88%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2669      +/-   ##
==========================================
- Coverage   84.80%   82.88%   -1.93%     
==========================================
  Files          47       47              
  Lines        9312     9358      +46     
==========================================
- Hits         7897     7756     -141     
- Misses       1415     1602     +187     

@germa89
Copy link
Collaborator Author

germa89 commented Jan 16, 2024

ignoring coverage

@germa89 germa89 self-assigned this Jan 16, 2024
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 2f4976a into main Jan 19, 2024
29 checks passed
@germa89 germa89 deleted the feat/removing-verbose branch January 19, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants