Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing with super() in custom error classes #2672

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 16, 2024

As the title.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jan 16, 2024
@germa89 germa89 requested a review from greschd January 16, 2024 17:00
@germa89 germa89 added Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc) labels Jan 16, 2024
@germa89 germa89 enabled auto-merge (squash) January 16, 2024 17:00
@github-actions github-actions bot added Maintenance General maintenance of the repo (libraries, cicd, etc) and removed Maintenance General maintenance of the repo (libraries, cicd, etc) labels Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (6db007d) 84.80% compared to head (0f47dc6) 82.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2672      +/-   ##
==========================================
- Coverage   84.80%   82.77%   -2.03%     
==========================================
  Files          47       47              
  Lines        9312     9313       +1     
==========================================
- Hits         7897     7709     -188     
- Misses       1415     1604     +189     

@germa89 germa89 merged commit 3bfa06d into main Jan 16, 2024
23 of 24 checks passed
@germa89 germa89 deleted the maint/using-super-to-create-custom-excepcions branch January 16, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants