Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test to DSCALE #2675

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Adding test to DSCALE #2675

merged 1 commit into from
Jan 17, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 17, 2024

As the title.

Since I had to write this code for testing #2674 I might as well add it to the tests.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jan 17, 2024
@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label Jan 17, 2024
@germa89 germa89 added Enhancement Improve any current implemented feature and removed BUG Issue, problem or error in PyMAPDL labels Jan 17, 2024
@germa89 germa89 requested a review from clatapie January 17, 2024 10:26
@germa89 germa89 added Maintenance General maintenance of the repo (libraries, cicd, etc) and removed Enhancement Improve any current implemented feature labels Jan 17, 2024
@germa89 germa89 enabled auto-merge (squash) January 17, 2024 10:26
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3bfa06d) 67.37% compared to head (cd8e47d) 82.77%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2675       +/-   ##
===========================================
+ Coverage   67.37%   82.77%   +15.39%     
===========================================
  Files          47       47               
  Lines        9313     9313               
===========================================
+ Hits         6275     7709     +1434     
+ Misses       3038     1604     -1434     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit f258bbf into main Jan 17, 2024
32 checks passed
@germa89 germa89 deleted the fix/converter-dscale branch January 17, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants