Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blacken #2719

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Update blacken #2719

merged 2 commits into from
Jan 30, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 30, 2024

Missing from #2716

When we update this line

rev: 24.1.1 # If version changes --> modify "blacken-docs" manually as well.
we need to also update
additional_dependencies: [black==23.12.1]

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the Maintenance General maintenance of the repo (libraries, cicd, etc) label Jan 30, 2024
@germa89 germa89 requested a review from clatapie January 30, 2024 10:00
@germa89 germa89 enabled auto-merge (squash) January 30, 2024 10:01
@germa89 germa89 self-assigned this Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a35cee) 85.00% compared to head (d951758) 82.97%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2719      +/-   ##
==========================================
- Coverage   85.00%   82.97%   -2.03%     
==========================================
  Files          47       47              
  Lines        9322     9322              
==========================================
- Hits         7924     7735     -189     
- Misses       1398     1587     +189     

@clatapie
Copy link
Contributor

Good catch!!

@germa89 germa89 merged commit 3fee354 into main Jan 30, 2024
29 checks passed
@germa89 germa89 deleted the maint/update-blacken branch January 30, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants