Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing memory footprint #2721

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 30, 2024

As the title.

Related to #2704

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 requested a review from clatapie January 30, 2024 17:44
@germa89 germa89 self-assigned this Jan 30, 2024
@github-actions github-actions bot added the Maintenance General maintenance of the repo (libraries, cicd, etc) label Jan 30, 2024
@germa89 germa89 added Enhancement Improve any current implemented feature and removed Maintenance General maintenance of the repo (libraries, cicd, etc) labels Jan 30, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (9f6be03) 85.00% compared to head (4f0bc3f) 78.64%.
Report is 2 commits behind head on main.

❗ Current head 4f0bc3f differs from pull request most recent head 8eced09. Consider uploading reports for the commit 8eced09 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2721      +/-   ##
==========================================
- Coverage   85.00%   78.64%   -6.36%     
==========================================
  Files          47       47              
  Lines        9323     9339      +16     
==========================================
- Hits         7925     7345     -580     
- Misses       1398     1994     +596     

@germa89
Copy link
Collaborator Author

germa89 commented Feb 9, 2024

@pyansys-ci-bot LGTM

Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 enabled auto-merge (squash) February 9, 2024 18:24
@germa89 germa89 merged commit 875ee1c into main Feb 9, 2024
22 checks passed
@germa89 germa89 deleted the maint/addressing-some-memory-issues branch February 9, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants