Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to converter #2749

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 5, 2024

As the title

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Feb 5, 2024
@germa89 germa89 added the Enhancement Improve any current implemented feature label Feb 5, 2024
@germa89 germa89 requested a review from clatapie February 5, 2024 12:09
@germa89
Copy link
Collaborator Author

germa89 commented Feb 5, 2024

Close #2747

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f6be03) 85.00% compared to head (aaeafd5) 82.97%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2749      +/-   ##
==========================================
- Coverage   85.00%   82.97%   -2.03%     
==========================================
  Files          47       47              
  Lines        9323     9323              
==========================================
- Hits         7925     7736     -189     
- Misses       1398     1587     +189     

@germa89
Copy link
Collaborator Author

germa89 commented Feb 5, 2024

@pyansys-ci-bot LGTM

Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 304ebb2 into main Feb 5, 2024
29 checks passed
@germa89 germa89 deleted the small-fixes-to-convert-module branch February 5, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert_script returns a INF instead of "INF" on the SF command and 'type' instead of skipping /TYPE.
2 participants