Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling session ID check by default #2778

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 14, 2024

This check penalise the performant quite a lot since several gRPC calls are made.

I'm disabling it for the moment.

Ideally we will have to implement something on the server side.

Close #2608

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Feb 14, 2024
@germa89 germa89 self-assigned this Feb 14, 2024
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 1b078da into main Feb 19, 2024
27 checks passed
@germa89 germa89 deleted the feat/disabling-check-session-by-default branch February 19, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance decline during loops after update to newer version of apdl-mapdl-core
2 participants