Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving example template #2794

Merged
merged 10 commits into from
Feb 19, 2024
Merged

Improving example template #2794

merged 10 commits into from
Feb 19, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 16, 2024

Improving example template and documentation.

Close #2370

Improving example descriptions
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Feb 16, 2024
@germa89 germa89 added the Documentation Documentation related (improving, adding, etc) label Feb 16, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Feb 16, 2024

@PipKat can I have another quick review please?

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The example template can be very useful

doc/source/getting_started/write_documentation.rst Outdated Show resolved Hide resolved
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@germa89 and @clatapie I agree that this is extremely useful information, but I think we should be placing lots of what is here in the PyAnsys developer's guide and then referencing from other PyAnsys libraries when applicable. In this case, I've covered much of the content about formatting reSTructuredText files in the PyAnsys writer's guide. Earlier this week, Roberto said I should initially integrate its content into the developer's guide by creating a new tabbed section--and then, over time, we can move, reorganize, and integrate content. I just hate the thought of repeating instead of referencing because it just requires more maintenance over time!

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com>
@germa89
Copy link
Collaborator Author

germa89 commented Feb 19, 2024

@germa89 and @clatapie I agree that this is extremely useful information, but I think we should be placing lots of what is here in the PyAnsys developer's guide and then referencing from other PyAnsys libraries when applicable. In this case, I've covered much of the content about formatting reSTructuredText files in the PyAnsys writer's guide. Earlier this week, Roberto said I should initially integrate its content into the developer's guide by creating a new tabbed section--and then, over time, we can move, reorganize, and integrate content. I just hate the thought of repeating instead of referencing because it just requires more maintenance over time!

I totally agree on this, you can leave me the links to the guides where these topics are detailed and I will add/replace when needed.
If these information is not yet contained in the guides, I would add them and then delete them when available.

@germa89 germa89 merged commit aba35fe into main Feb 19, 2024
27 checks passed
@germa89 germa89 deleted the doc/iimproving-examples-docs branch February 19, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework the "example" example
3 participants