Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more error catching #2901

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Adding more error catching #2901

merged 5 commits into from
Mar 18, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 15, 2024

As the title.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@wiz-inc-572fc38784
Copy link
Contributor

wiz-inc-572fc38784 bot commented Mar 15, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

@germa89 germa89 self-assigned this Mar 15, 2024
@germa89 germa89 requested a review from clatapie March 15, 2024 22:20
@germa89 germa89 added the Enhancement Improve any current implemented feature label Mar 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.61%. Comparing base (304ebb2) to head (2ff4c9a).
Report is 97 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2901      +/-   ##
==========================================
- Coverage   85.00%   84.61%   -0.39%     
==========================================
  Files          47       48       +1     
  Lines        9323     9412      +89     
==========================================
+ Hits         7925     7964      +39     
- Misses       1398     1448      +50     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 3c3bbae into main Mar 18, 2024
30 checks passed
@germa89 germa89 deleted the feat/more-error-catching branch March 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants