Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linkchecker workflow #2906

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Fix linkchecker workflow #2906

merged 5 commits into from
Mar 19, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 18, 2024 •
edited

As the title.

Close #2903

@germa89 germa89 requested a review from a team as a code owner March 18, 2024 18:57
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) BUG Issue, problem or error in PyMAPDL labels Mar 18, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Mar 18, 2024 •
edited

The workflow gets stuck forever...

https://github.com/ansys/pymapdl/actions/runs/8332107123/job/22800496328

@germa89
Copy link
Collaborator Author

germa89 commented Mar 19, 2024 •
edited by unfurl-links bot

Waiting for this to finish

https://github.com/ansys/pymapdl/actions/runs/8341531741/job/22827750274

GitHub
Pythonic interface to MAPDL. Contribute to ansys/pymapdl development by creating an account on GitHub.

@germa89
Copy link
Collaborator Author

germa89 commented Mar 19, 2024 •
edited by unfurl-links bot

Waiting for this to finish

https://github.com/ansys/pymapdl/actions/runs/8341531741/job/22827750274

GitHub**LinkCheck - All files 🔗 · ansys/pymapdl@95efcd6**Pythonic interface to MAPDL. Contribute to ansys/pymapdl development by creating an account on GitHub.

This passed. 👍

GitHub
Pythonic interface to MAPDL. Contribute to ansys/pymapdl development by creating an account on GitHub.

@germa89 germa89 enabled auto-merge (squash) March 19, 2024 12:24
clatapie
clatapie approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Using DPF image as a global environment variable could be an option but it's up to you.

.github/workflows/linkchecker.yml Show resolved Hide resolved
.github/workflows/linkchecker.yml Show resolved Hide resolved
@germa89 germa89 merged commit ba6d8fe into main Mar 19, 2024
30 checks passed
@germa89 germa89 deleted the fix/linkchecker-workflow branch March 19, 2024 20:45
@germa89
Copy link
Collaborator Author

germa89 commented Mar 19, 2024 •
edited

@clatapie, merging main in this branch does not make sense because on PRs we do not run this workflow, and in other PRS we do not change this workflow either.

image

Good software developers know when you can save resources ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie clatapie approved these changes

@pyansys-ci-bot pyansys-ci-bot Awaiting requested review from pyansys-ci-bot pyansys-ci-bot is a code owner automatically assigned from ansys/pymapdl-maintainers

Assignees
No one assigned
Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LinkChecker workflow fails
2 participants
@germa89 @clatapie