Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc builds in Windows #2922

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Fix doc builds in Windows #2922

merged 4 commits into from
Mar 21, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 21, 2024

As the title.

The issue was an infinite loop while launching MAPDL.

Once I added:

from ansys.mapdl.core import LOG

LOG.setLevel("DEBUG")
LOG.log_to_file("mylog.log")

to the first example, I was able to get:

DEBUG - pymapdl_global -  launcher - launch_mapdl - Using default port 50052
DEBUG - pymapdl_global -  launcher - launch_mapdl - Building gallery.
DEBUG - pymapdl_global -  launcher - get_start_instance - PYMAPDL_START_INSTANCE is unset. Using default value True.  
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using 'start_instance' equal to True.
DEBUG - pymapdl_global -  launcher - launch_mapdl - No IP address was supplied. Using the default IP address: 127.0.0.1
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using default port 50052
DEBUG - pymapdl_global -  launcher - launch_mapdl - Building gallery.
DEBUG - pymapdl_global -  launcher - get_start_instance - PYMAPDL_START_INSTANCE is unset. Using default value True.  
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using 'start_instance' equal to True.
DEBUG - pymapdl_global -  launcher - launch_mapdl - No IP address was supplied. Using the default IP address: 127.0.0.1
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using default port 50052
DEBUG - pymapdl_global -  launcher - launch_mapdl - Building gallery.
DEBUG - pymapdl_global -  launcher - get_start_instance - PYMAPDL_START_INSTANCE is unset. Using default value True.  
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using 'start_instance' equal to True.
DEBUG - pymapdl_global -  launcher - launch_mapdl - No IP address was supplied. Using the default IP address: 127.0.0.1
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using default port 50052
DEBUG - pymapdl_global -  launcher - launch_mapdl - Building gallery.
DEBUG - pymapdl_global -  launcher - get_start_instance - PYMAPDL_START_INSTANCE is unset. Using default value True.  
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using 'start_instance' equal to True.
DEBUG - pymapdl_global -  launcher - launch_mapdl - No IP address was supplied. Using the default IP address: 127.0.0.1
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using default port 50052
DEBUG - pymapdl_global -  launcher - launch_mapdl - Building gallery.
DEBUG - pymapdl_global -  launcher - get_start_instance - PYMAPDL_START_INSTANCE is unset. Using default value True.  
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using 'start_instance' equal to True.
DEBUG - pymapdl_global -  launcher - launch_mapdl - No IP address was supplied. Using the default IP address: 127.0.0.1
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using default port 50052
DEBUG - pymapdl_global -  launcher - launch_mapdl - Building gallery.
DEBUG - pymapdl_global -  launcher - get_start_instance - PYMAPDL_START_INSTANCE is unset. Using default value True.  
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using 'start_instance' equal to True.
DEBUG - pymapdl_global -  launcher - launch_mapdl - No IP address was supplied. Using the default IP address: 127.0.0.1
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using default port 50052
DEBUG - pymapdl_global -  launcher - launch_mapdl - Building gallery.
DEBUG - pymapdl_global -  launcher - get_start_instance - PYMAPDL_START_INSTANCE is unset. Using default value True.  
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using 'start_instance' equal to True.
DEBUG - pymapdl_global -  launcher - launch_mapdl - No IP address was supplied. Using the default IP address: 127.0.0.1
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using default port 50052
DEBUG - pymapdl_global -  launcher - launch_mapdl - Building gallery.
DEBUG - pymapdl_global -  launcher - get_start_instance - PYMAPDL_START_INSTANCE is unset. Using default value True.  
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using 'start_instance' equal to True.
DEBUG - pymapdl_global -  launcher - launch_mapdl - No IP address was supplied. Using the default IP address: 127.0.0.1
DEBUG - pymapdl_global -  launcher - launch_mapdl - Using default port 50052
DEBUG - pymapdl_global -  launcher - launch_mapdl - Building gallery.

I had to introduce an stop flag "loading...", so it is forced to

Close #2921

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the BUG Issue, problem or error in PyMAPDL label Mar 21, 2024
@germa89 germa89 requested a review from clatapie March 21, 2024 09:37
@germa89 germa89 self-assigned this Mar 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (2780f04) to head (4aa183e).
Report is 1 commits behind head on main.

❗ Current head 4aa183e differs from pull request most recent head 6661334. Consider uploading reports for the commit 6661334 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2922      +/-   ##
==========================================
- Coverage   86.62%   84.69%   -1.94%     
==========================================
  Files          48       48              
  Lines        9461     9461              
==========================================
- Hits         8196     8013     -183     
- Misses       1265     1448     +183     

@germa89
Copy link
Collaborator Author

germa89 commented Mar 21, 2024

By the way, the bug was introduced in #2854 but I do not understand why the linux build is not affected. Only the Windows one.

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the explanations 👍

@germa89 germa89 merged commit f5cf6ce into main Mar 21, 2024
30 checks passed
@germa89 germa89 deleted the fix/doc-builds-in-windows branch March 21, 2024 10:42
@germa89 germa89 mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows doc builds fail
3 participants