Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add argument to disable run_at_connect in MapdlGrpc #3049

Merged
merged 6 commits into from May 3, 2024
Merged

add argument to disable run_at_connect in MapdlGrpc #3049

merged 6 commits into from May 3, 2024

Conversation

Gryfenfer97
Copy link
Contributor

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Apr 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.14%. Comparing base (42ef513) to head (14839b7).
Report is 11 commits behind head on main.

❗ Current head 14839b7 differs from pull request most recent head c958d9a. Consider uploading reports for the commit c958d9a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3049      +/-   ##
==========================================
- Coverage   86.68%   84.14%   -2.54%     
==========================================
  Files          52       52              
  Lines        9498     9499       +1     
==========================================
- Hits         8233     7993     -240     
- Misses       1265     1506     +241

germa89
germa89 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Gryfenfer97 and others added 2 commits May 2, 2024 15:48
@germa89 @PipKat
Update src/ansys/mapdl/core/mapdl_grpc.py
c958d9a 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@germa89 germa89 enabled auto-merge (squash) May 3, 2024 08:14
@germa89 germa89 merged commit 1701afb into main May 3, 2024
27 checks passed
@germa89 germa89 deleted the feat/disable-run-at-connect branch May 3, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@germa89 germa89 germa89 approved these changes

Assignees
No one assigned
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gryfenfer97 @codecov-commenter @germa89 @PipKat