Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Skipping test_xpl.py::test_save on v24.2 (#2905)" #3088

Merged
merged 1 commit into from
May 14, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented May 14, 2024

This reverts commit ea42836.

The bug should have been fixed by now.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this May 14, 2024
@germa89 germa89 added the BUG label May 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (598e2e8) to head (295d0a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3088      +/-   ##
==========================================
- Coverage   86.64%   84.16%   -2.49%     
==========================================
  Files          52       52              
  Lines        9553     9553              
==========================================
- Hits         8277     8040     -237     
- Misses       1276     1513     +237     

@germa89
Copy link
Collaborator Author

germa89 commented May 14, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) May 14, 2024 11:06
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 9efcf04 into main May 14, 2024
34 checks passed
@germa89 germa89 deleted the fix/activate-xpl-test branch May 14, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants