Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger implementation and tests #265

Merged
merged 59 commits into from Jun 13, 2023
Merged

Logger implementation and tests #265

merged 59 commits into from Jun 13, 2023

Conversation

koubaa
Copy link
Collaborator

@koubaa koubaa commented Jun 8, 2023

Embedding logging is only currently possible to configure by setting environment variables before starting mechanical.

This adds an API that allows initial configuration but also configuration at runtime after initializing the app.

This will aid in debugging/diagnosing runtime issues.

I am working on documentation, and will add it in subsequent commits in this PR

@github-actions github-actions bot added the bug Something isn't working label Jun 8, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 8, 2023
@github-actions github-actions bot added CI/CD maintenance Package and maintenance related labels Jun 8, 2023
RobPasMue
RobPasMue approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking great @koubaa!

doc/source/user_guide_embedding/index.rst Outdated Show resolved Hide resolved
src/ansys/mechanical/core/embedding/logger/__init__.py Outdated Show resolved Hide resolved
koubaa and others added 2 commits June 9, 2023 07:44
@koubaa @RobPasMue
Update doc/source/user_guide_embedding/index.rst
f97e88f 
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@koubaa @RobPasMue
Update src/ansys/mechanical/core/embedding/logger/__init__.py
955edae 
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@koubaa koubaa requested a review from PipKat June 9, 2023 12:44
koubaa and others added 28 commits June 12, 2023 12:22
@koubaa @PipKat
Update src/ansys/mechanical/core/embedding/logger/windows_api.py
6a7c231 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@koubaa @PipKat
Update doc/source/user_guide_embedding/logging.rst
50cbefb 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@koubaa @PipKat
Update src/ansys/mechanical/core/embedding/logger/__init__.py
aea1d79 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
sentences
f40e60e
Merge branch 'fix-embedding-logger' of https://github.com/ansys/pymec…
643d68d 
…hanical into fix-embedding-logger
@koubaa @PipKat
Update src/ansys/mechanical/core/embedding/logger/__init__.py
3f25cd4 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@koubaa @PipKat
Update src/ansys/mechanical/core/embedding/logger/__init__.py
7de78e9 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@koubaa @PipKat
Update src/ansys/mechanical/core/embedding/logger/__init__.py
e2f5041 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@koubaa @PipKat
Update src/ansys/mechanical/core/embedding/logger/__init__.py
ae139db 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@koubaa @PipKat
Update src/ansys/mechanical/core/embedding/logger/__init__.py
f5069ba 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@koubaa @PipKat
Update src/ansys/mechanical/core/embedding/logger/environ.py
4dd3d21 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
wording
66c66c7
@koubaa @PipKat
Update src/ansys/mechanical/core/embedding/logger/__init__.py
cf50fbd 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@koubaa @PipKat
Update src/ansys/mechanical/core/embedding/logger/__init__.py
3323cd1 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@koubaa @PipKat
Update src/ansys/mechanical/core/embedding/logger/__init__.py
d404f61 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
taketh away the givens
55832f8
@koubaa @PipKat
Update src/ansys/mechanical/core/embedding/logger/environ.py
44fef61 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@koubaa @PipKat
Apply suggestions from code review
aaf76f9 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
42c7e4c 
for more information, see https://pre-commit.ci
let this sink in
88f1c20
try
e516ec6
debug
bc1507b
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d8aa019 
for more information, see https://pre-commit.ci
try
a9cb58f
Merge branch 'fix-embedding-logger' of https://github.com/ansys/pymec…
19243d1 
…hanical into fix-embedding-logger
test
db56010
@RobPasMue
Merge branch 'main' into fix-embedding-logger
217a878
style
5db20a2
@koubaa koubaa merged commit e0bbbc1 into main Jun 13, 2023
31 checks passed
@koubaa koubaa deleted the fix-embedding-logger branch June 13, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat approved these changes

@RobPasMue RobPasMue RobPasMue approved these changes

@samigithub2022 samigithub2022 Awaiting requested review from samigithub2022

Assignees
No one assigned
Labels
bug Something isn't working CI/CD documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@koubaa @RobPasMue @PipKat