Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Double description of client config vars #29

Merged
merged 1 commit into from Feb 9, 2024

Conversation

tmpbeing
Copy link
Collaborator

@tmpbeing tmpbeing commented Feb 9, 2024

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Feb 9, 2024
@awoimbee
Copy link
Collaborator

awoimbee commented Feb 9, 2024

I think the class level docs is for sphinx and the field level is for clients that want to extend the SDK (eg if someone wanted to write a cli c; ). This comes from PR 961 on the other repo.
If you've checked that the docs are not impacted let's merge, otherwise I think we're stuck with duplicated field docs.

@tmpbeing
Copy link
Collaborator Author

tmpbeing commented Feb 9, 2024

It does in fact work as expected

@tmpbeing tmpbeing force-pushed the fix/double-description-client-config-vars branch from 0a73fc0 to 497d823 Compare February 9, 2024 11:05
@tmpbeing tmpbeing merged commit 7e8f413 into main Feb 9, 2024
4 checks passed
@tmpbeing tmpbeing deleted the fix/double-description-client-config-vars branch February 9, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants