Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try new secret to file #128

Closed
wants to merge 3 commits into from
Closed

try new secret to file #128

wants to merge 3 commits into from

Conversation

Acohen-work
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the maintenance Package and maintenance related label Apr 9, 2024
@@ -103,7 +103,7 @@ jobs:
docker pull ghcr.io/ansys/ansys-api-turbogrid/tglin_reduced:241

- name: Create Key
uses: mobiledevops/secret-to-file-action@v1
uses: Acohen-work/secret-to-file-action@v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alex, we can not have personal things in the project

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the lib is MIT license we can fork the lib to ansys org.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No license in the repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No license does not mean you can distribute. If you need this action, it should be moved to the ansys org and go under the OSS process. Since this is very specific of this project, the best way to speed up things is that you emulate the goal of this action in a shell script that is hosted in this repository.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion sounds reasonable to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgepiloto the action is a node.js script which handles the secrecy details of the file as well. If you have another route to securely handling secret->file then we can go that way, if not, why not simply fork this action into ansys actions? It surely is generically useful.

Copy link
Member

@jorgepiloto jorgepiloto May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to achieve the same result, you can do the following:

base64 -d <<< ${{ secrets.CONTAINER_ACCESS_KEY }} > tg_container_key

This redirects the secret without echoing, decodes it, and saves it in a file.

@Acohen-work
Copy link
Collaborator Author

no need since js 20 is used automatically now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants