Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect argument order in pytwin.evaluate.twin_model.generate_points() #104

Closed
2 tasks done
EDCarman opened this issue Aug 7, 2023 · 0 comments · Fixed by #106
Closed
2 tasks done

Incorrect argument order in pytwin.evaluate.twin_model.generate_points() #104

EDCarman opened this issue Aug 7, 2023 · 0 comments · Fixed by #106
Assignees
Labels
bug Something isn't working

Comments

@EDCarman
Copy link
Collaborator

EDCarman commented Aug 7, 2023

🔍 Before submitting the issue

  • I have searched among the existing issues
  • I am using a Python virtual environment

🐞 Description of the bug

The named_selection argument is the first argument for the function and is not optional. This is inconsistent with other similar functions e.g. generate_snapshot().

Additionally, the docstring lists named_selection as being the third argument and optional.

📝 Steps to reproduce

from pytwin import TwinModel
model1 = TwinModel('model.twin')
model1.initialize_evaluation()
romname = model1.tbrom_names[0]
nslist = model1.get_named_selections(romname)
# Generate a snapshot
fieldresults = model1.generate_snapshot(romname, False, nslist[0])
# Try to generate points with same arguments
points= model1.generate_snapshot(romname, False, nslist[0])

💻 Which operating system are you using?

Windows

📀 Which ANSYS version are you using?

No response

🐍 Which Python version are you using?

3.9

📦 Installed packages

colorama==0.4.6
contourpy==1.1.0
coverage==7.2.7
cycler==0.11.0
exceptiongroup==1.1.2
fonttools==4.41.0
importlib-metadata==6.8.0
importlib-resources==6.0.0
iniconfig==2.0.0
kiwisolver==1.4.4
matplotlib==3.7.2
numpy==1.25.1
packaging==23.1
pandas==2.0.3
Pillow==10.0.0
pluggy==1.2.0
pyparsing==3.0.9
pytest==7.4.0
pytest-cov==4.1.0
python-dateutil==2.8.2
-e git+https://github.com/pyansys/pytwin@ec3594c2f4f343d36dfa12bb35e6e6e78fffc638#egg=pytwin
pytz==2023.3
pywin32==306
six==1.16.0
tomli==2.0.1
tzdata==2023.3
zipp==3.16.1
@EDCarman EDCarman added the bug Something isn't working label Aug 7, 2023
@EDCarman EDCarman self-assigned this Aug 8, 2023
@EDCarman EDCarman linked a pull request Aug 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant