Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documnetation issue with Multi-Language #159

Closed
Zhuangkh opened this issue May 28, 2020 · 3 comments · Fixed by #470
Closed

Documnetation issue with Multi-Language #159

Zhuangkh opened this issue May 28, 2020 · 3 comments · Fixed by #470
Labels
🐛bug Something isn't working documentation Improvements or additions to documentation

Comments

@Zhuangkh
Copy link
Contributor

I know the project only supports Simplified Chinese and English for now. However, if the browser does not use these two languages by default (e.g. Traditional Chinese), it will return unexpected pages, and some components will get 404 errors.

Does the project plan to support more languages or fix this routing error?😍
@ElderJames ElderJames added the 🐛bug Something isn't working label May 28, 2020
@ElderJames
Copy link
Member

Thank you for reporting this issue! @Zhuangkh
The correct behavior is to default to English for unsupported languages. I think there's something wrong

@ElderJames ElderJames added this to the 0.1.0 milestone May 28, 2020
@ElderJames ElderJames mentioned this issue May 29, 2020
Closed
@ElderJames
Copy link
Member

Before fixing this issue, you can fix it by clicking the language switch button in the upper right corner.

@ElderJames ElderJames mentioned this issue Jun 25, 2020
Closed
@ElderJames ElderJames added the documentation Improvements or additions to documentation label Jul 2, 2020
@ElderJames ElderJames mentioned this issue Jul 7, 2020
Closed
@ElderJames ElderJames changed the title Issue with Multi-Language Documnetation issue with Multi-Language Jul 7, 2020
@ElderJames ElderJames modified the milestones: 0.2.0 - MILESTONE: July 2020, 0.3.0 - MILESTONE: August 2020 Aug 1, 2020
@ElderJames ElderJames linked a pull request Aug 10, 2020 that will close this issue
fix(docs): handles fallback to en-US if resources are not available #470
Merged
16 tasks
@ElderJames
Copy link
Member

fixed via #470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(docs): handles fallback to en-US if resources are not available
2 participants
@ElderJames @Zhuangkh