Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): handles fallback to en-US if resources are not available #470

Merged
merged 2 commits into from
Aug 6, 2020
Merged

fix(docs): handles fallback to en-US if resources are not available #470

merged 2 commits into from
Aug 6, 2020

Conversation

diegofrata
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

The website is completely broken when accessing from a computer with a culture different from either en-US or zn-CH. This PR fixes the LanguageService to fallback to en-US when needed.

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@ElderJames
Copy link
Member

/preview

@github-actions
Copy link

github-actions bot commented Aug 6, 2020

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@ElderJames ElderJames merged commit ace567e into ant-design-blazor:master Aug 6, 2020
@diegofrata diegofrata deleted the fix-default-culture branch August 7, 2020 18:01
@ElderJames ElderJames linked an issue Aug 10, 2020 that may be closed by this pull request
Zhuangkh pushed a commit to Zhuangkh/ant-design-blazor that referenced this pull request Sep 25, 2020
ElderJames added a commit that referenced this pull request Oct 15, 2020
ElderJames added a commit that referenced this pull request Apr 23, 2022
ElderJames added a commit that referenced this pull request Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documnetation issue with Multi-Language
2 participants