Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:menudivider): Add Menu divider #1017

Merged
merged 5 commits into from
Jan 22, 2021

Conversation

anddrzejb
Copy link
Member

馃 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃挕 Background and solution

Added new component MenuDivider.
Update to docs:

  • menu divider usage in Dropdown
  • menu divider usage in Menu
  • tooltip usage with Dropdown (change includes added loading icon to sync with react ant-design docs)

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@codecov-io
Copy link

codecov-io commented Jan 21, 2021

Codecov Report

Merging #1017 (8667ef0) into master (ce117b5) will decrease coverage by 0.13%.
The diff coverage is 3.74%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1017      +/-   ##
=========================================
- Coverage    5.69%   5.55%   -0.14%     
=========================================
  Files         412     423      +11     
  Lines       22030   22289     +259     
=========================================
- Hits         1254    1238      -16     
- Misses      20776   21051     +275     
Impacted Files Coverage 螖
components/affix/Affix.razor 0.00% <0.00%> (酶)
components/affix/Affix.razor.cs 0.00% <0.00%> (酶)
components/anchor/Anchor.razor 0.00% <0.00%> (酶)
components/anchor/Anchor.razor.cs 0.00% <0.00%> (酶)
components/anchor/AnchorLink.razor 0.00% <0.00%> (酶)
components/anchor/AnchorLink.razor.cs 0.00% <0.00%> (酶)
components/auto-complete/AutoComplete.razor 0.00% <0.00%> (酶)
components/auto-complete/AutoComplete.razor.cs 0.00% <酶> (酶)
components/auto-complete/AutoCompleteInput.cs 0.00% <0.00%> (酶)
components/auto-complete/AutoCompleteSearch.cs 0.00% <0.00%> (酶)
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update fe56d81...8667ef0. Read the comment docs.

@ElderJames ElderJames merged commit 030cbdf into ant-design-blazor:master Jan 22, 2021
@anddrzejb anddrzejb deleted the menuDivider branch January 22, 2021 05:24
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
* feat(module:menudivider): new component

* docs(module:dropdown): dropdown with tooltip and menudivider

* docs(module:menu): menudivider for horizontal demo

* feat(module:menudivider): remove unnecessary method
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
* feat(module:menudivider): new component

* docs(module:dropdown): dropdown with tooltip and menudivider

* docs(module:menu): menudivider for horizontal demo

* feat(module:menudivider): remove unnecessary method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants