fix(module:menu): fix loop on same route & performance & duplicate highlight #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix duplicate highlight fixes 737 fixes 833 fixes 919 fixes 1014
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
=========================================
- Coverage 5.69% 5.55% -0.15%
=========================================
Files 412 422 +10
Lines 22030 22298 +268
=========================================
- Hits 1254 1238 -16
- Misses 20776 21060 +284
Continue to review full report at Codecov.
|
This was
linked to
issues
Jan 22, 2021
Closed
|
We also need to add the expand/collapse animation of the submenu. |
|
Yeah, I noticed that. I will try to do some work in that area. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
#737
#833
#919
#1014
💡 Background and solution
All changes are directly connected with issues.
Plus performance optimization, as stated below.
During tests I found out that single click was causing cascading calls that were causing multiple unnecessary refreshes. After some serious debugging and trial and error I think I got to the point it is only doing necessary calls. Just to give a ballpark figure - with 5 menus, single click was causing 5 refreshes of each menu on average (my total was 29 refreshes overall). With this PR only changing menus are refreshing (so 2 changes in total - what is weird, 3 refreshes if order of menu clicking is reversed).
☑️ Self Check before Merge