-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:menu): fix loop on same route & performance & duplicate highlight #1027
fix(module:menu): fix loop on same route & performance & duplicate highlight #1027
Conversation
fix duplicate highlight fixes 737 fixes 833 fixes 919 fixes 1014
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
=========================================
- Coverage 5.69% 5.55% -0.15%
=========================================
Files 412 422 +10
Lines 22030 22298 +268
=========================================
- Hits 1254 1238 -16
- Misses 20776 21060 +284
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We also need to add the expand/collapse animation of the submenu. |
Yeah, I noticed that. I will try to do some work in that area. |
🤔 This is a ...
🔗 Related issue link
#737
#833
#919
#1014
💡 Background and solution
All changes are directly connected with issues.
Plus performance optimization, as stated below.
During tests I found out that single click was causing cascading calls that were causing multiple unnecessary refreshes. After some serious debugging and trial and error I think I got to the point it is only doing necessary calls. Just to give a ballpark figure - with 5 menus, single click was causing 5 refreshes of each menu on average (my total was 29 refreshes overall). With this PR only changing menus are refreshing (so 2 changes in total - what is weird, 3 refreshes if order of menu clicking is reversed).
☑️ Self Check before Merge