Feat/row class name #1031
Merged
Feat/row class name #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first ever PR so my apologies for any mistakes or errors. I tried to follow the guidelines provided to the best of my ability. |
Codecov Report
@@ Coverage Diff @@
## master #1031 +/- ##
=========================================
- Coverage 5.49% 5.49% -0.01%
=========================================
Files 424 426 +2
Lines 23095 23128 +33
=========================================
Hits 1270 1270
- Misses 21825 21858 +33
Continue to review full report at Codecov.
|
|
Thank you for you contribution @mostrowski123 It's very nice. |
ElderJames
requested changes
Jan 23, 2021
components/table/Table.razor
Outdated
| @@ -184,7 +184,7 @@ RenderFragment<(Table<TItem> table, bool header)> colGroup = ctx => | |||
| } | |||
| @if (!hasChildren && table.ExpandTemplate != null && table.RowExpandable(currentRowData)) | |||
| { | |||
| <tr class="ant-table-expanded-row ant-table-expanded-row-level-1" style="@(currentRowData.Expanded?"":"display: none;")"> | |||
| <tr class="ant-table-expanded-row ant-table-expanded-row-level-1 @table.RowClassName(currentRowData)" style="@(currentRowData.Expanded?"":"display: none;")"> | |||
There was a problem hiding this comment.
Here is an other peroperty for expand row.
ElderJames
approved these changes
Jan 24, 2021
ElderJames
added a commit
that referenced
this pull request
Apr 23, 2022
* feat(module: table): add row styling * docs: add RowClassName to docs * docs: add custom row style subtext * feat(module: table): add ExpandedRowClassName * remove RowClassName for expand row * add chinese doc Co-authored-by: ElderJames <shunjiey@hotmail.com>
ElderJames
added a commit
that referenced
this pull request
Apr 30, 2022
* feat(module: table): add row styling * docs: add RowClassName to docs * docs: add custom row style subtext * feat(module: table): add ExpandedRowClassName * remove RowClassName for expand row * add chinese doc Co-authored-by: ElderJames <shunjiey@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#1025
💡 Background and solution
There currently is no way of conditionally applying styles to rows in a table. This is useful if you want to highlight a row conditionally based on the row data.
I fixed this by adding a
Func<RowData<TItem>, string> RowClassNameparameter to the table component and queried its value in the class attribute where rows are created.📝 Changelog
I should note there is an issue when hovering on the highlighted rows as the hover color overrides the any color set by the custom style. I am not sure if this is acceptable or not, but I was unable to find a way to darken the color that is set. My apologies.
☑️ Self Check before Merge