Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: image): add image component #1038

Merged
merged 3 commits into from
Jan 24, 2021
Merged

feat(module: image): add image component #1038

merged 3 commits into from
Jan 24, 2021

Conversation

ElderJames
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@codecov-io
Copy link

Codecov Report

Merging #1038 (1874728) into master (9fb9bff) will decrease coverage by 0.00%.
The diff coverage is 0.91%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1038      +/-   ##
=========================================
- Coverage    5.48%   5.47%   -0.01%     
=========================================
  Files         426     433       +7     
  Lines       23170   23284     +114     
=========================================
+ Hits         1270    1274       +4     
- Misses      21900   22010     +110     
Impacted Files Coverage Δ
components/image/Image.razor 0.00% <0.00%> (ø)
components/image/Image.razor.cs 0.00% <0.00%> (ø)
components/image/ImageLocale.cs 0.00% <0.00%> (ø)
components/image/ImagePreview.razor.cs 0.00% <0.00%> (ø)
components/image/ImagePreviewContainer.razor 0.00% <0.00%> (ø)
components/image/ImagePreviewContainer.razor.cs 0.00% <0.00%> (ø)
components/image/ImageService.cs 0.00% <0.00%> (ø)
components/locale-provider/Locale.cs 0.00% <0.00%> (ø)
components/space/SpaceItem.razor.cs 0.00% <0.00%> (ø)
...nts/core/Extensions/ServiceCollectionExtensions.cs 88.23% <100.00%> (+0.73%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb9bff...1874728. Read the comment docs.

@ElderJames ElderJames merged commit a54cbe7 into master Jan 24, 2021
@ElderJames ElderJames deleted the feat/image branch January 24, 2021 18:05
@ElderJames ElderJames linked an issue Feb 19, 2021 that may be closed by this pull request
ElderJames added a commit that referenced this pull request Apr 23, 2022
* feat(module: image): add image

* add image preview

* add locale
ElderJames added a commit that referenced this pull request Apr 30, 2022
* feat(module: image): add image

* add image preview

* add locale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sync 4.6.0] Add image component
2 participants