Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: steps navigation was blocked #1071

Merged
merged 2 commits into from
Feb 3, 2021
Merged

fix: steps navigation was blocked #1071

merged 2 commits into from
Feb 3, 2021

Conversation

Tfurrer
Copy link
Contributor

@Tfurrer Tfurrer commented Feb 3, 2021

馃 This is a Bug Fix

馃敆 Related issue link

馃挕 Background and solution

I believe that we should be invoking a State Change here. Currently the navigation is not working otherwise.

馃摑 Changelog

I am not aware of any breaking changes here.

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

I believe that we should be invoking a State Change here. Currently the navigation is not working otherwise.
@ElderJames ElderJames changed the title Update Step.razor.cs fix: steps navigation was blocked Feb 3, 2021
ElderJames
ElderJames previously approved these changes Feb 3, 2021
Resolved error from Disposal
@Tfurrer
Copy link
Contributor Author

Tfurrer commented Feb 3, 2021

Resolved an issue with the Disposal and invoke state change

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit cd9ea41 into ant-design-blazor:master Feb 3, 2021
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
* Update Step.razor.cs

I believe that we should be invoking a State Change here. Currently the navigation is not working otherwise.

* Update Step.razor.cs

Resolved error from Disposal
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
* Update Step.razor.cs

I believe that we should be invoking a State Change here. Currently the navigation is not working otherwise.

* Update Step.razor.cs

Resolved error from Disposal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants