fix(module:rangepicker): placeholder and value equals null #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 4, 2021
Closed
ElderJames
approved these changes
Feb 4, 2021
ElderJames
added a commit
that referenced
this pull request
Apr 23, 2022
Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames
added a commit
that referenced
this pull request
Apr 30, 2022
Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃敆 Related issue link
#1068
#1070
馃挕 Background and solution
If
Valueprovided toRangePickerwas null, it was throwingNullReferenceException. Now during initialization, theValueis checked and ifnull, it is instantiated toTValue.Placeholders were not reset on clear - are now.
鈽戯笍 Self Check before Merge